search

Rosewood-Development / PlayerPoints

A free plugin for points currency (with SQL support)
GNU General Public License v3.0
61 stars 47 forks source link

Fix other plugins get wrong points using placeholderapi #7

Closed DreamVoid closed 3 years ago

DreamVoid commented 3 years ago

Some plugin(such as DeluxeMenus) need to use %playerpoints_points% to get player's points. But this placeholder will return a number with character ",". This mean if a player has 5000 points, and when other plugin judge "%playerpoints_points% >=3000", it will return "false". Sorry for my poor English. I am Chinese.

FakEEE14 commented 3 years ago

use the latest source, latest is fixed this problem https://github.com/Rosewood-Development/PlayerPoints/commit/4406dd03a22431c4587f5899f0bfde2ab9d5206c

Esophose commented 3 years ago

use the latest source, latest is fixed this problem 4406dd0

That commit is unrelated to the issue referenced here.

Some plugin(such as DeluxeMenus) need to use %playerpoints_points% to get player's points. But this placeholder will return a number with character ",". This mean if a player has 5000 points, and when other plugin judge "%playerpoints_points% >=3000", it will return "false".

Thank you for this, didn't think about that. I'm going to modify the placeholder code myself to add a new one to get the points formatted and will keep the old one as the old format. Thank you for the pull request though.

Fixed in cbd679c6a19c713d5d79025e2cda6f899c8f7ece

FakEEE14 commented 3 years ago

but on the new update you add in https://github.com/Rosewood-Development/PlayerPoints/commit/4406dd03a22431c4587f5899f0bfde2ab9d5206c you can set the currency separator to empty and this work and change the placeholder too