search

Rosewood-Development / RoseStacker

A next-generation stacker plugin for Spigot and Paper servers
Other
141 stars 38 forks source link

Please add the support for TrHologram #10

Closed ahdg6 closed 3 years ago

ahdg6 commented 4 years ago

Please add hologram handler for TrHologram It's a packet-based hologram plugin,I think It would be a practical feature if you add the support for it. Sincerely hoping you can consider it,thank you. github:https://github.com/Arasple/TrHologram doc:https://trhologram.trixey.cn/api/usage

Esophose commented 3 years ago

Unfortunately it looks like that plugin is currently inactive. If it becomes active again and supports 1.16.4, I'll add support for it.

ahdg6 commented 3 years ago

This plugin is still working on 1.16.4. and the developer of it is developing another premium plugin called TrMenu that meant TrHologram is still being supported,but without further feature being developed.

Esophose commented 3 years ago

It does not support 1.16.4 or any version of 1.16, I know this because I tested it myself https://prnt.sc/vqa58q. After letting the server load for over 5 minutes while that plugin downloaded dependencies, it then just errored on startup and failed to load.

ahdg6 commented 3 years ago

Taboolib:https://github.com/TabooLib/TabooLib You need to get dependence from here to load it,It must be put on the libs file which in the root path of server

./libs/TabooLib.jar Screenshot_20201126_140304

Thank you for your patience.

Esophose commented 3 years ago

I already have that there though. Here's my startup log if you don't believe me latest.log

ahdg6 commented 3 years ago

I'm sorry to reply so late. I have no idea why it can't be loaded for you,but It's still working on my 1.16.4 Paper Server. Try to use this to replace the Taboolib.jar:https://1drv.ms/u/s!Asmkq8Fp9qN-grwsUswmiuqgmmsAZg

Skiller9090 commented 3 years ago

image TrHologram does appear to still be working in 1.16.4 paper-332 as shown above

Esophose commented 3 years ago

I just tried re-downloading it again and still can't get it to work on 1.16.4 using paper-391. I just get a several separate errors. Here is my startup log for proof: https://pastebin.com/2hFJ1nz1 I've tried using the latest versions on both Spigot and GitHub, neither work.

Esophose commented 3 years ago

Okay I stand corrected. After deleting libs/TabooLib.jar, deleting the plugins/TabooLib folder, and downgrading to Java 8 only then did it finally work. I had to jump through so many random hoops to get that working, ugh.

Esophose commented 3 years ago

@Skiller9090 @ahdg6 I can't get the commands working, all it does is throw errors. Can you give me some example commands to run just to create a hologram with the text Test? Everything I try to do with this plugin just ends up giving me trouble. Edit: Also the GitHub repo is marked as read-only so I can only assume that this plugin has been abandoned. Still extremely on the fence about adding support for it when there are other hologram plugins that are significantly better and more stable.

Skiller9090 commented 3 years ago

Will do when i get up out of bed in 7 hours, if you want @Esophose i can program the hologramHandler for the plugin for you

Esophose commented 3 years ago

I'm fine with adding it myself as it's pretty much an identical process to the other ones, I just have no idea why this plugin is giving me so much trouble with commands and such. I'll implement it real quick and report back on if it works or not.

Esophose commented 3 years ago

If one of you could test this jar and send a screenshot of the hologram if it works that would be great. It's still refusing to create any holograms on my server and is just giving me errors.

Commit: 7e5862ea75b1c544e55bd7a2d8028f408557199f Jar: RoseStacker-1.1.5.zip

Skiller9090 commented 3 years ago

alright ill give a test

Skiller9090 commented 3 years ago

image Good start image it is working all good image No lingering either perfection :)

Esophose commented 3 years ago

The holograms are only used for stacked spawners and blocks, the entities and items just use the nametags. Try placing a stacked spawner and block to see if the hologram support worked.

Skiller9090 commented 3 years ago

alright: image

Skiller9090 commented 3 years ago

image Getting no errors in console either

Skiller9090 commented 3 years ago

image after deletion there is no lingering

Esophose commented 3 years ago

Needs to be moved down by half a block I guess but other than that looks good

Skiller9090 commented 3 years ago

yep well done 👍

Esophose commented 3 years ago

Are you able to contact me on discord so I can just continue messaging you there? Nicole#0001

Esophose commented 3 years ago

TrHologram support has been added and will be in the next update.

Skiller9090 commented 3 years ago

@ahdg6 Here is the beta version working with TrHolograms if you still need it! RoseStacker-1.1.5.zip