Rosewood-Development / RoseStacker

A next-generation stacker plugin for Spigot and Paper servers
Other
139 stars 36 forks source link

[Request] some config option additions and changes #21

Closed Nubebuster closed 3 years ago

Nubebuster commented 3 years ago

Entities currently always insta-stack from a spawner. This is great for performance (I presume) but I like the entities to spawn seperately and then merge when they get into my desired stacking range. Could you add an option to set insta-stack true or false for spawners too like you have in global-entity-settings (which I presume to be only for natural spawning) ?

Could you make an option for making spawn-max-nearby-entities take stacked mobs into account? Otherwise I will have to set it to 1

PS I appreciate the previous additions. They were precisely what I wanted!

Esophose commented 3 years ago

I thought both of those settings already existed but it turns out neither of them actually do. They should be pretty simple to add.

Nubebuster commented 3 years ago

Also an unrelated question

/give nubebuster spawner{display:{Name:'[{"text":"Cat Spawner","italic":false,"color":"gray"}]'}} 1 gives me a cat spawner that works with your plugin. But it does not stack with spawners using the /rs give

Should I care about the item difference and what is the difference?

Esophose commented 3 years ago

The spawner referenced in that give command doesn't have the entity type stored on it, all you did was rename it. If you properly include the entity type NBT on it then it should stack with other spawners properly. The way it is now RoseStacker and Minecraft itself will see it as a pig spawner.

The /rs give command will give you a spawner item that has custom NBT that RoseStacker uses to determine the stack size and amount. The plugin also supports the vanilla NBT for the entity type to be more compatible with other plugins.

Esophose commented 3 years ago

Added in 7634c76396d0e90c77ec28b625fcef5e9c9f2ba0

Edit: Additionally just released v1.2.8 on Spigot with those changes