search

Rosewood-Development / RoseStacker

A next-generation stacker plugin for Spigot and Paper servers
Other
137 stars 35 forks source link

Fix null pointer #85

Closed RAVINGAR closed 10 months ago

RAVINGAR commented 1 year ago

Fixed a small null pointer that was causing an issue under some circumstances. Can't compile it myself as maven-public repo is private :/

Esophose commented 1 year ago

I do agree something should be done to fix the potential for null issues like this. I think the stack setting getters should be changed to return NonNull values and instead return an empty settings container where everything just returns empty. I'll keep this PR open as I want to fix the overarching issue, I just don't think this is entirely the right way to go about it as there are 10+ other areas in the code which would need identical changes.