search

Rosey / markdown-draft-js

A tool to convert content created in DraftJS to markdown and vice versa.
https://rosey.github.io/markdown-draft-js/
MIT License
317 stars 70 forks source link

Render preserved new lines after list correctly #146

Closed TrySound closed 3 years ago

TrySound commented 4 years ago

Found an issue in my editor after sending form (serialize->deseriaize) newlines after lists are increased.

TrySound commented 4 years ago

Hi @Rosey. Could you take a look if you have some time?

TrySound commented 3 years ago

Friendly ping @Rosey

TrySound commented 3 years ago

Hi @Rosey Friendly ping

chrisrobbins commented 3 years ago

@Rosey Friendly ping here, I know you are very busy. Any chance you can give some info on when you might have some time to take a look at this PR?

Rosey commented 3 years ago

sorry team! merging now.

@chrisrobbins thanks for the twitter ping, another maintainer would be useful 😭 The job that I worked where we were using this library I no longer work at so I don't have any work-related excuse to look at this anymore, and not any personal time either 😓

Anything to do with newline behaviour I am wary of merging without testing super carefully because I find it's a finicky area and every bug fix seems to introduce a different bug 😛 I kind of regret adding support for it 😆 Merged this one because it seems fairly straightfoward though 🙂

TrySound commented 3 years ago

Thank you Rose

chrisrobbins commented 3 years ago

Thank you!