search

Rosey / markdown-draft-js

A tool to convert content created in DraftJS to markdown and vice versa.
https://rosey.github.io/markdown-draft-js/
MIT License
317 stars 70 forks source link

Strikethrough conversion is incomplete #156

Closed tobiaspatton-s4 closed 3 years ago

tobiaspatton-s4 commented 3 years ago

markdownToDraft(string, options) includes support for writing markdown with strikethrough text enclosed with ~~ but draftToMarkdown(rawDraftObject, options) does not include support for creating a DraftJS inline style when the ~~ marker is encountered.

It's possible to add a custom entry to BlockStyles when invoking the conversion routine, but since default support is included in one direction, it makes sense to support it in the other direction as well.

I'll create a PR for this issue.

Rosey commented 3 years ago

Thanks for your PR 🙂 merged it and will close this!