WIP: Typescript - Githubissues

Rosey / markdown-draft-js

A tool to convert content created in DraftJS to markdown and vice versa.

https://rosey.github.io/markdown-draft-js/

MIT License

318 stars 69 forks source link

WIP: Typescript #92

Closed charliewilco closed 4 years ago

charliewilco commented 5 years ago

[ ] Converts setup from Babel to TypeScript
[ ] Migrates Jasmine / Karma / Browserify to Jest with TypeScript
[ ] Uses Prettier for code formatting over eslint

TODO:

[ ] Correct all type errors
[ ] Passing tests
[ ] Add generated typings to package.json

Rosey commented 5 years ago

Thanks for getting this started! Question: did we need to convert all single quotes to double quotes? It feels like the js community generally prefers single quotes for strings so I liked sticking with that standard 😊

charliewilco commented 5 years ago

not at all! double quotes are just prettier's default. switched it up

yurist38 commented 4 years ago

Hello! Do you guys plan to move it forward? I just used this package in TS project, have written type definitions inside my project for now. So I'm wondering if you are still planning to convert it to TS. Or if it's not going forward should I open a PR with .d.ts file instead?

charliewilco commented 4 years ago

i actually haven't had time to come back to this.