search

Roshan-R / termv

A terminal iptv player written in bash
GNU General Public License v3.0
222 stars 19 forks source link

Minor language fixes or opinionated changes in the rewrite branch #14

Closed Kabouik closed 2 years ago

Kabouik commented 2 years ago

The work done on the rewrite branch is really awesome, thanks @odnar-dev!

I initially just wanted to add a comment in the existing PR because I saw a typo at dependencie, but then I saw a couple other ones in a variable name and syntax issues so I thought it would be best if I fixed them directly. I eventually added a couple more subjective changes to the answers for the channels.json update process, but it's very minor, just let me know if you want me to change it back to what it was.i

Also changed unsorted into n/a because I think it's less cluttered and more standard for cases where data is not available. Being short and containing a / also makes it stand out visually from cases where the data is available, and the / should ensure that it does not conflict with words containing na when filtering in fzf.

Roshan-R commented 2 years ago

Thanks for the PR @Kabouik I'm a fan of the new update process and changing unsorted into n/a and thanks for removing the typos :sweat_smile: