search

RosieSews / masksnow

The masksnow.org website
https://masksnow.org
7 stars 9 forks source link

Change title headings to h1 #64

Closed Shelob9 closed 4 years ago

Shelob9 commented 4 years ago

I started PR #63 to address SEO component. In #7 @gvan12 said

it's important for PSAs page to make the H1 "PSAs" that way google doesn't think the first celebrity endoresement is the title.

The SEO rule, as I understand it, is one h1 tag per page, and that should be title of the page. Right now, many but not all templates use h2 for the title.

This PR changes all page titles to use h1 tags for headings.

Shelob9 commented 4 years ago

Change looks good - but we didn't have prettier set up on git hooks to keep style changes out of commits. Would you mind getting the latest from master and trying this again? You can configure your IDE to use those tools on the fly instead of just waiting for the git hook to run it too (It's what I do!)

Yes, I can. I think my settings for Prettier extension in .vscode were used when I saved the files. I'll fix that and push again.

Shelob9 commented 4 years ago

Closing. Use #71 instead please.