search

RosieSews / masksnow

The masksnow.org website
https://masksnow.org
7 stars 9 forks source link

Move page title up and remove blue bar #73

Open Shelob9 opened 4 years ago

Shelob9 commented 4 years ago

Fixes #72

gvan12 commented 4 years ago

But the validator card makes it look like there is no description. So the property likely exists but is a blank string? I can dig more later tonight.

On Thu, Apr 2, 2020, 6:15 PM Josh Pollock notifications@github.com wrote:

@Shelob9 commented on this pull request.

In src/components/SEO.js https://github.com/RosieSews/masksnow/pull/73#discussion_r402649365:

  • //Description may be set, else, use excerpt
  • if (postMeta.hasOwnProperty('description')) {
  • description = postMeta.description;
  • } else if (postNode.hasOwnProperty('excerpt')) {
  • description = postNode.excerpt;

I think one of those two checks aren't actually working as they are always overwriting the siteDescription.

If the post has frontmatter.description, it is overwriting siteDescription

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/RosieSews/masksnow/pull/73#discussion_r402649365, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2H6HKDN3QPH2ATT24LJM3RKUMBVANCNFSM4L2W5P6A .

gvan12 commented 4 years ago

I believe the SEO work you've done here is merged into a branch on the repo called seo-work here: https://github.com/RosieSews/masksnow/tree/seo-work

If that's the case - I think we can close this one - feel free to pick back up on the seo stuff on that branch - it's a little closer to current state of master than this one is now.