search

RosieSews / masksnow

The masksnow.org website
https://masksnow.org
7 stars 9 forks source link

front page edit to make it more obvious that we accept all mask patterns #88

Closed cqrmskgiub closed 4 years ago

cqrmskgiub commented 4 years ago

Feature request

What is the expected behavior? on front page, in section "Donate Masks" add text under "YOUR STATE LEAD WILL EMAIL YOU WITH DIRECTIONS ABOUT HOW & WHERE". text to say "we will donate all masks no matter what pattern you use" or something of the sort.

What is motivation or use case for adding/changing the behavior? to make sure people know that we donate all masks, they don't have to use our pattern.

How should this be implemented in your opinion? same as above

Are you willing to work on this yourself? can't

cqrmskgiub commented 4 years ago

alternatively or additionally, under "get the pattern" it can say (or use any pattern of your choosing)

alfdocimo commented 4 years ago

Hi @cqrmskgiub! First of all nice to meet you! I've taken on this issue and have added both texts to each section: Get the pattern image Donate Masks image

I've used the same styles as the warning (*PERSONAL USE ONLY) text for consistency.

Could this be enhanced in any way? color, position, padding? I could use some advice.

Also: please ignore the images having a weird non-transparent background. Seems to be a gatsby issue for windows users 😰 [https://github.com/gatsbyjs/gatsby/issues/14497]

gvan12 commented 4 years ago

I'll wait until @cqrmskgiub responds for a definitive answer - but if you could either add a prop to the component so it can flex it's styling to not have margin-left in this scenario I think that would be better. Color, size, style, all look good to me!

cqrmskgiub commented 4 years ago

Agree with Garrett, currently the added text is aligned with the bullet text, would like the text to be aligned with the bullets under "get pattern" (and text under "donate masks").

Please change the new text in "donate masks" to: "Every mask made will be donated, no matter what pattern you use". Also would prefer to have more margin or padding above this text.

Thanks so much!!

On Sat, Apr 11, 2020 at 08:35 Garrett notifications@github.com wrote:

I'll wait until @cqrmskgiub https://github.com/cqrmskgiub responds for a definitive answer - but if you could either add a prop to the component so it can flex it's styling to not have margin-left in this scenario I think that would be better. Color, size, style, all look good to me!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RosieSews/masksnow/issues/88#issuecomment-612448356, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG56MJUOEG7UPKS2AMEG3FTRMCE4XANCNFSM4MFZYBIQ .

gvan12 commented 4 years ago

It's using the style for the warning, do you want those warning texts to have more top Margin as well? Can be different just need to know for to implement.

On Sat, Apr 11, 2020, 12:54 PM cqrmskgiub notifications@github.com wrote:

Agree with Garrett, currently the added text is aligned with the bullet text, would like the text to be aligned with the bullets under "get pattern" (and text under "donate masks").

Please change the new text in "donate masks" to: "Every mask made will be donated, no matter what pattern you use". Also would prefer to have more margin or padding above this text.

Thanks so much!!

On Sat, Apr 11, 2020 at 08:35 Garrett notifications@github.com wrote:

I'll wait until @cqrmskgiub https://github.com/cqrmskgiub responds for a definitive answer - but if you could either add a prop to the component so it can flex it's styling to not have margin-left in this scenario I think that would be better. Color, size, style, all look good to me!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/RosieSews/masksnow/issues/88#issuecomment-612448356 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AG56MJUOEG7UPKS2AMEG3FTRMCE4XANCNFSM4MFZYBIQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/RosieSews/masksnow/issues/88#issuecomment-612477200, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2H6HLEUIA6VPQGGFR3UCTRMCVG7ANCNFSM4MFZYBIQ .

cqrmskgiub commented 4 years ago

On second thought!!

Only for the "every mask made text", change it to same style as "your state lead will email you" and link it to: https://rosiesews.freshdesk.com/support/solutions/articles/61000268414-can-i-use-a-different-pattern-than-what-you-provide-

On Sat, Apr 11, 2020 at 11:00 Garrett notifications@github.com wrote:

It's using the style for the warning, do you want those warning texts to have more top Margin as well? Can be different just need to know for to implement.

On Sat, Apr 11, 2020, 12:54 PM cqrmskgiub notifications@github.com wrote:

Agree with Garrett, currently the added text is aligned with the bullet text, would like the text to be aligned with the bullets under "get pattern" (and text under "donate masks").

Please change the new text in "donate masks" to: "Every mask made will be

donated, no matter what pattern you use". Also would prefer to have more

margin or padding above this text.

Thanks so much!!

On Sat, Apr 11, 2020 at 08:35 Garrett notifications@github.com wrote:

I'll wait until @cqrmskgiub https://github.com/cqrmskgiub responds for a definitive answer - but if you could either add a prop to the component so it can flex it's styling to not have margin-left in this scenario I think that would be better. Color, size, style, all look good to me!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/RosieSews/masksnow/issues/88#issuecomment-612448356 , or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AG56MJUOEG7UPKS2AMEG3FTRMCE4XANCNFSM4MFZYBIQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://github.com/RosieSews/masksnow/issues/88#issuecomment-612477200 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AB2H6HLEUIA6VPQGGFR3UCTRMCVG7ANCNFSM4MFZYBIQ

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RosieSews/masksnow/issues/88#issuecomment-612478444, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG56MJTSCZM42X2RJGZCRTDRMCV4RANCNFSM4MFZYBIQ .

gvan12 commented 4 years ago

Thanks! Should be set on this now!

On Sat, Apr 11, 2020, 1:25 PM cqrmskgiub notifications@github.com wrote:

On second thought!!

Only for the "every mask made text", change it to same style as "your state lead will email you" and link it to:

https://rosiesews.freshdesk.com/support/solutions/articles/61000268414-can-i-use-a-different-pattern-than-what-you-provide-

On Sat, Apr 11, 2020 at 11:00 Garrett notifications@github.com wrote:

It's using the style for the warning, do you want those warning texts to have more top Margin as well? Can be different just need to know for to implement.

On Sat, Apr 11, 2020, 12:54 PM cqrmskgiub notifications@github.com wrote:

Agree with Garrett, currently the added text is aligned with the bullet text, would like the text to be aligned with the bullets under "get pattern" (and text under "donate masks").

Please change the new text in "donate masks" to: "Every mask made will be

donated, no matter what pattern you use". Also would prefer to have more

margin or padding above this text.

Thanks so much!!

On Sat, Apr 11, 2020 at 08:35 Garrett notifications@github.com wrote:

I'll wait until @cqrmskgiub https://github.com/cqrmskgiub responds for a definitive answer - but if you could either add a prop to the component so it can flex it's styling to not have margin-left in this scenario I think that would be better. Color, size, style, all look good to me!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/RosieSews/masksnow/issues/88#issuecomment-612448356 , or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AG56MJUOEG7UPKS2AMEG3FTRMCE4XANCNFSM4MFZYBIQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/RosieSews/masksnow/issues/88#issuecomment-612477200 , or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AB2H6HLEUIA6VPQGGFR3UCTRMCVG7ANCNFSM4MFZYBIQ

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/RosieSews/masksnow/issues/88#issuecomment-612478444 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AG56MJTSCZM42X2RJGZCRTDRMCV4RANCNFSM4MFZYBIQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/RosieSews/masksnow/issues/88#issuecomment-612483616, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2H6HPLSV4CZ6G7MFYLA4LRMCYZPANCNFSM4MFZYBIQ .

alfdocimo commented 4 years ago

Got it! created a PR for this. Please let me know if I can improve anything! (: