Rosmaninho / Zotero-Dark-Theme

userChrome.css file for a Zotero dark theme. Suggestions for improvements are welcome.
GNU General Public License v3.0
721 stars 95 forks source link

Unreadable color combination when a collection is highlighted #16

Closed marco-coraggio closed 2 years ago

marco-coraggio commented 3 years ago

When an article is selected, and Ctrl is pressed, the collection in which the article is present is highlighted in yellow. However the name of the collection remains white, and white on yellow background is not very readable. image_37 k.

Thank you so much for this beautiful work.

Rosmaninho commented 2 years ago

Weird, I can't replicate this. What version of Zotero is this?

Ak5cel commented 2 years ago

Same on mine, version 5.0.96.3

Weird, I can't replicate this. What version of Zotero is this?

Steps to replicate:

  1. Add the same item to multiple collections
  2. Click on the item in one collection and press Ctrl, all the other collections the item is in would be highlighted

It can be found in the support docs here.

marco-coraggio commented 2 years ago

Thanks @Ak5cel for the explanation. This can also be replicated like this

I'm using verison 5.0.96.3 of Zotero

Rosmaninho commented 2 years ago

Thanks! I managed to replicate it like this. Man, there are some truly edge cases. It's good you caught this in 5.0.96.3. The next version will break a lot of stuff because the Zotero devs are re-writing a lot of the code so I don't want to tackle it before a final release version since a lot might change before then. I will merge the pull request.

marco-coraggio commented 2 years ago

Thank you so much @Rosmaninho. Very cool name btw!