search

Rostlab / JS16_ProjectA

In this project we will lay the foundations for our system by integrating data from multiple sources into a central database. The database will serve the apps and the visualization tool that will be developed in other projects.
GNU General Public License v3.0
28 stars 14 forks source link

Fix find on PLODS per algorythm #137

Closed sacdallago closed 8 years ago

sacdallago commented 8 years ago

https://api.got.show/api/plod/byAlgorithm/gotarffplod https://api.got.show/api/plod/byAlgorithm/gotplod

just return the first hit on find, while they should return the whole list of PLODS for that alg.

Please inform @togiberlin because I haven't seen him on here ever since we started with the PLOD problems and he is the main responsible for this.

Legenzoo commented 8 years ago

@sacdallago I´ve notified him on facebook.

Legenzoo commented 8 years ago

Just change https://github.com/Rostlab/JS16_ProjectA/blob/master/app/stores/charactersPlod.js#L60

message[0] -> message. Better remove the whole if clause since both cases are the same.

sacdallago commented 8 years ago

Yeah, probably the check should be .length > 0 otherwise 404, but this is implemented like shit.

Legenzoo commented 8 years ago

The 404 check is in the controller. Unfortunately in the beginning some mistakes have been done (like error not being the first callback parameter, but success or somewhat), that are now spread all over. We would have needed the presentations in the beginning and one experienced member in NodeJs :anguished:

sacdallago commented 8 years ago

I agree. I'll propose to change the way the seminar is hold with nex sem, there's a lot of space for improvement!

The thing that bothers me is mostly that @togiberlin disappeared. An -any- sign of life would have made a big difference in these days, especially considering that yesterday was the deadline and things can go wrong until the deadline

togiberlin commented 8 years ago

@sacdallago I already announced it, I have on 6th April an exam. I suggest this seminar to be a 10 ECTS Praktikum. Then there is upwards a lot more room

togiberlin commented 8 years ago

@sacdallago please pull newest version to server. Issue can be closed