Rostlab / JS16_ProjectB_Group6

Game of Thrones characters are always in danger of being eliminated. The challenge in this assignment is to see at what risk are the characters that are still alive of being eliminated. The goal of this project is to rank characters by their Percentage Likelihood of Death (PLOD). You will assign a PLOD using machine learning approaches.
GNU General Public License v3.0
3 stars 4 forks source link

Project directory structure #24

Closed jsalahov closed 8 years ago

jsalahov commented 8 years ago

Hello there, people. As you should have noticed, tests are failing :smile_cat: Reason is directory structure has changed, so tests can't "require" modules. So the question is : Is this the final directory structure of the project?

asesselmann commented 8 years ago

No, because we are not even near to starting our real task (implementing the support vector machine).

The files in the weka folder worked with the provided dummy data, the files in the api-handler folder work with the actual data of Project A's database.

The structure will keep changing, maybe its best if we notify you, when we have the final (or even nearly final) structure.

Maybe one of the others has a better idea?

jsalahov commented 8 years ago

If there will be any commit that changes the directories or breaks the tests in any other way, assign the pull request to me. I'll modify the tests if needed and then merge your pull request.

subburamr commented 8 years ago

@CavidSalahov Just as a headsup, due to change in project deliverable we would be removing the svm(no longer being implemented) and weka(was just used for preliminary task) folders from our final deliverable

The attached image is likely to be our final project structure. So you can make changes to the tests accordingly. For now, we will retain the weka folder to ensure the build doesn't fail.

project_structure

jsalahov commented 8 years ago

Well, you can also delete the contents of the spec folder, as they also became irrelevant. Build should fail then

jsalahov commented 8 years ago

@subburamr Is it safe to delete everything that is not pictured here? :smiling_imp:

subburamr commented 8 years ago

Closing this as #64 contains the final project structure

ThuyNganTran commented 8 years ago

I added a new directory for the PLOD of the houses (or other stats) so the final project structure is not up-to-date anymore. As for now, only a csv file, a .js file containing minor code and a node package are inside so no real tests are necessary though.

jsalahov commented 8 years ago

@ThuyNganTran It is safe to change the directory structure, as tests are not relevant now