search

Rostlab / JS16_ProjectD_Group5

Joffrey Baratheon is one of the most loathed characters in TV history. As a matter of fact people were celebrating his TV death on Twitter. We are interested to learn more on how people feel about different characters by analyzing tweets mentioning GoT characters. In this project you will be analyzing Twitter feeds across a timeline, you will look for the name of GoT characters in that feed and try to identify whether the tweet is positive or negative. You can then generate a metric that evaluates what is the accumulated sentiment expressed on Twitter for that given character at a given point in time, and what is the trend (positive, negative). It will be interesting to intersect the sentiments for characters following the airing of a certain episode (you can easily get the airing date for an episode from the database constructed in Project A).
GNU General Public License v3.0
2 stars 3 forks source link

Feature freeze and testing #91

Closed jcebel closed 8 years ago

jcebel commented 8 years ago

@sacdallago @yashha (please add the other tutors. Can't remember the names and with my mobile I don't get the suggestions) We have discovered a Major Design error as we started the testing in Index.js (this is the Ui). All functions get a json in which the User specifies the search query(e.g. Name of character, date etc.) The Problem is that the propertyname where the charactername gets stored is unconsistent (it's sometimes Name, charactername or just character). Also the response json contains a property where the character Name gets stored. There also unconsistency over the whole application. We want to change all property-names to "character" if it is ok to Do such a Major change After Feature freeze. We would Do that in heavy cooperation with F as they are the Main USER of the App at the moment. Please respond with any thoughts questiona etc.

sacdallago commented 8 years ago

This needs to be done. It's unthinkable to have inconsistent data at the first release :D

sacdallago commented 8 years ago

P.S.: in FF you stop implementing features and try to avoid changing the functionality, but if stuff like this comes up, you un-try to avoid it :laughing: Also, I don't think it's such a major change for the end user, it's actually a simplification.

End of the story: just do it and let F know when it's done, possibly sooner than later

kajo404 commented 8 years ago

On it

jcebel commented 8 years ago

@yashha I just saw that I did not write it in the notification, but this has also been change with the deployment yesterday. Please consult the readme or me if you're having questions :)