Fixed issue that charts has been loaded twice - Githubissues

Rostlab / JS16_ProjectF

In this project we will build a web portal for our GoT data analysis and visualization system. The website will integrate all the apps created in projects B-D with the help of the integration team assigned to Project E.

GNU General Public License v3.0

10 stars 8 forks source link

Fixed issue that charts has been loaded twice #432

Closed sacdallago closed 8 years ago

sacdallago commented 8 years ago

Revert, reverted original PR #430 in favor of further testing before deployment and merge with develop.

The fast way of testing this is someone coming to rostlab tomorrow with this version running somewhere locally, the long way is me setting up a testing server.

yashha commented 8 years ago

Chrome:

yashha commented 8 years ago

That was not a big change

yashha commented 8 years ago

I can run a test heroku if you want. Edit: Maybe just @mammuth @jorjo1 start it and check it?

yashha commented 8 years ago

It is only a fix for #369

sacdallago commented 8 years ago

Yes please, try to deploy back on heroku! I'll try it out tomorrow with a couple macs, see if it solves the other problem as well (I really believe it should)

yashha commented 8 years ago

You don't use our staging branch, do you?

sacdallago commented 8 years ago

Nope I use develop!

yashha commented 8 years ago

Wait I can't really use it too. Because it would have to merge first into develop, I'll make a new branch.

yashha commented 8 years ago

So now lets wait until there shows something on the charts :D I deployed. https://got-stats.herokuapp.com/ Edit: and it works

sacdallago commented 8 years ago

Will test it out in an hour! Thank you!

sacdallago commented 8 years ago

Fantastic. This indeed seems to solve also #396

marcusnovotny commented 8 years ago

Guys, great job. I keep coming back to got.show and the site looks a little more amazing every day. Thanks for your loyal service! :grin: