search

Rostlab / JS16_ProjectF

In this project we will build a web portal for our GoT data analysis and visualization system. The website will integrate all the apps created in projects B-D with the help of the integration team assigned to Project E.
GNU General Public License v3.0
10 stars 8 forks source link

Fixed switching from statistics and back and removed donut #450

Closed yashha closed 8 years ago

yashha commented 8 years ago

Closes #426, #416

yashha commented 8 years ago

no review?

sacdallago commented 8 years ago

it's broken

sacdallago commented 8 years ago

screen shot 2016-04-16 at 1 43 01 am

sacdallago commented 8 years ago

I reopened the branch and reverted the PR. Please fix the error and open a new PR @yashha

yashha commented 8 years ago

Thats strange: image

sacdallago commented 8 years ago

My thesis is confirmed! The other PR broke this one!

What's gonna happen now:

  1. I will undo the changes of #449
  2. Please fix whatever causes the problem for the tweets to be always set to 0
  3. You shall open a new PR for this branch, which will be merged and is approved right away

For now I'm running the checkout of commit: 3e1856fd98e131032eb2c7fa976959b38f56b841 that came before the PR merge of #449

and this seems to be working

Good job btw! :D Needless to say that the problem could just arise by having the code of both PRs.. and who would have thought....