search

Rostlab / JS16_ProjectF

In this project we will build a web portal for our GoT data analysis and visualization system. The website will integrate all the apps created in projects B-D with the help of the integration team assigned to Project E.
GNU General Public License v3.0
10 stars 8 forks source link

legal notice on header #490

Closed jorjo1 closed 8 years ago

jorjo1 commented 8 years ago

https://github.com/Rostlab/JS16_ProjectF/issues/482

sacdallago commented 8 years ago

Screenshot please?

jorjo1 commented 8 years ago

image

gyachdav commented 8 years ago

smaller font and within 0.5 opacity div On Apr 22, 2016, at 1:40 PM, Georgi Anastasov notifications@github.com wrote:

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

jorjo1 commented 8 years ago

image

jorjo1 commented 8 years ago

So now we have a gridded content on the page, but the header looks a lot better now - full width. Forget about this floating nowhere elements now :dancer:

sacdallago commented 8 years ago

Something like: header

?

sacdallago commented 8 years ago

You are also very welcome to just take that image and substitute it in the right location :D

jorjo1 commented 8 years ago

If I take your image, @sacdallago , we are again in trouble because we don't see the whole image - smaller screens see that different from bigger screens. So why not leave this as a text? You mean I have to make it with our Cinzel font?

sacdallago commented 8 years ago

Definitely use the approach that you most like! I was just pointing out on the "style". I wouldn't have the text with a background grayish color, because: who cares! As long as there is the intention that we have it, and the text is selectable, it's good enough :)

Edit also, fontwise: whatever you like! :)

sacdallago commented 8 years ago

? anything here? :)

yashha commented 8 years ago

image Edit: image It seems like the navbar is still messed up

yashha commented 8 years ago

I think this can be merged

sacdallago commented 8 years ago

@yashha weren't you talking about the nav-bar being messed up?

Same story as earlier, I would prefer develop to be merged into this branch and then to have a new PR to see that nothing is breaking.

Please open a new PR once develop --> header-legal

yashha commented 8 years ago

still messed up It will be fixed with #475 because I shrinked the fontsize of the header there.

yashha commented 8 years ago

changes of this pr still working image