search

Rostlab / JS16_ProjectF

In this project we will build a web portal for our GoT data analysis and visualization system. The website will integrate all the apps created in projects B-D with the help of the integration team assigned to Project E.
GNU General Public License v3.0
10 stars 8 forks source link

Added tum bar at top 2.0 #494

Closed yashha closed 8 years ago

yashha commented 8 years ago

Well, hm image

sacdallago commented 8 years ago

Very nice @yashha Last thing I would like to try out is: use the dark color-scheme, similar to the one I put on the comment using the colors of the corporate design

Maybe also @jorjo1 and/or @mammuth can help?

Again: thank you! This looks exactly like they want to have it.

goldbergtatyana commented 8 years ago

All, since we're working on the front page, can we please have the rostlab logo centered in the footer? Thanks!

jorjo1 commented 8 years ago

@sacdallago @goldbergtatyana Should TUM logo be this big?

gyachdav commented 8 years ago

No merging until I say so. This issue is now on hold until further notice.

yashha commented 8 years ago

I think the map page has to be adjusted, before merge.

Am 23. Apr. 2016, 13:38, um 13:38, Georgi Anastasov notifications@github.com schrieb:

Should TUM logo be this big?

You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/Rostlab/JS16_ProjectF/pull/494#issuecomment-213725300

mammuth commented 8 years ago

Not only the map. You need to higher the main containers padding with the height of the new tum-bar.

On Sat, Apr 23, 2016, 13:46 yashha notifications@github.com wrote:

I think the map page has to be adjusted, before merge.

Am 23. Apr. 2016, 13:38, um 13:38, Georgi Anastasov < notifications@github.com> schrieb:

Should TUM logo be this big?

You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/Rostlab/JS16_ProjectF/pull/494#issuecomment-213725300

— You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub https://github.com/Rostlab/JS16_ProjectF/pull/494#issuecomment-213725996

sacdallago commented 8 years ago

Me @gyachdav and @goldbergtatyana just talked and again the idea is:

You can go on working, this is not on hold anymore :P

The above are official colors for both background and text, which can be found here https://portal.mytum.de/pressestelle/tum_mit/2007nr2/09.pdf on the third page, the third set of colors on the right.

You can find all the logos and specification of the corporate design here: https://portal.mytum.de/corporatedesign/index_html by accessing with your TUM credentials

Apart from that, please work on the other fixes that @mammuth and @yashha talked about.

@jorjo1 The size is "imposed" by the logo and corporate design. I know this is annoying as fuck but again: better do it right then having them tell us to re-do it for the fourth time now.

Please, like you always do, send us screenshots when you have something to show and thank you again :)

sacdallago commented 8 years ago

Hi guys, anything on this regard? We got another email from the legal office asking if we "accepted their conditions" :P :P

gyachdav commented 8 years ago

Rephrasing what @sacdallago just said - we need this done ASAP. Should be up live within the hour. Whoever is I front of a laptop please take care now.

This coming from the president of the university!

yashha commented 8 years ago

I don't have access to any of the guidlines on https://portal.mytum.de/corporatedesign/index_html. Are they important?

@sacdallago Do you want this on the top of the page? https://cloud.githubusercontent.com/assets/6240943/14739285/e3c168da-0886-11e6-8a10-7e4f63884d92.jpg

sacdallago commented 8 years ago

Yes please @yashha I can give you the pngs and color for the background, hold on

yashha commented 8 years ago

Why not the svgs, I am currently using?

sacdallago commented 8 years ago

Official white TUM logo: tum_logo_weiss_rgb_p

It's white... :D so you probably won't see it here :D :D :D :D just click on it, open it, and download it

sacdallago commented 8 years ago

Color scheme:

  1. 353535 --> https://www.colorcodehex.com/353535/
  2. 828282 --> https://www.colorcodehex.com/828282/
  3. cecece --> https://www.colorcodehex.com/cecece/

I would say 353535 for background! You should use the same background color for the rest of the page (I have tried to inspect the page and change the body { background: #1f1f1f; ..} to body { background: #353535; ..} and you can barely see the difference!

Edit: It looks terrible on the rankings page. Just keep the two different backgrounds and send us a screenshot please.. Should not look that bad

Thanks

yashha commented 8 years ago

Its a bit brighter than before: image

sacdallago commented 8 years ago

Good @yashha we are almost there. How about keeping the body color the same? Screenshot of that please?

yashha commented 8 years ago

image Is there no darker color provided by tum?

sacdallago commented 8 years ago

Unfortunately not 😢

I would keep this last one, @gyachdav I need your ok and @goldbergtatyana as well

gyachdav commented 8 years ago

Green light to merge from me and I okay for @goldbergtatyana too

dont wait with the merge please.

sacdallago commented 8 years ago

Ok than please @yashha commit your last work and I will close this :)

Thank you soso much

yashha commented 8 years ago

Now I still have to fix some spacings, because of the new bar at the top we have to adjust the spacings of many pages.

sacdallago commented 8 years ago

Ping me when it's time to review and merge :)

yashha commented 8 years ago

It's done. :) @sacdallago I don't know, maybe @jorjo1 or @mammuth check if every spacing is fixed Or we deploy it and fix it with an quickfix afterwards

gyachdav commented 8 years ago

In merging. Chris deploy ASAP.

All please go over and prepare hotfixes. We need this done ASAP.

gyachdav commented 8 years ago

@yashha put in the following changes:

TUMLogoWritten{ margin-top:: 50px;} TUMLogo{ remove margin-top or margin-top:0px;}

please modify asap.

yashha commented 8 years ago

So a smaller bar? @gyachdav image

gyachdav commented 8 years ago

yes way way shorter. please check on mobile, i only checked with dev tools that this works on desktops

yashha commented 8 years ago

image s5: image

yashha commented 8 years ago

shell I make it short like on mobile on desktop too?

gyachdav commented 8 years ago

Yes