Rothamsted-Ecoinformatics / farm_rothamsted

Custom farmOS features for Rothamsted Research.
GNU General Public License v2.0
6 stars 1 forks source link

Rothamsted core: page caching when changing between users #576

Open aislinnpearson opened 1 year ago

aislinnpearson commented 1 year ago

When switching between different user profiles as part of the testing for issue #373 I noticed that the edit button shows for 'view only' profiles on pages which have previously been edited that same user when they previously had editing rights. However, if you click on the edit button, the 'view only' users do not actually have the permission to edit.

Speaking to @paul121 about this it appears to be a page caching issue. We agreed he'd have a look into it if he has time for milestone 2.17.x but that if it was not resolved there we would mark it as a known issue not for resolving unless it becomes obvious it is a problem, as we don't envisage regularly changing users from viewers to editors.

@paul121 - feel free to close if resolved, but if not I'll move it to the list of 'won't fix' issues.

paul121 commented 1 year ago

I've done some more testing and haven't been able to reproduce. Definitely want to fix if we can figure out how it is happening. It might be easier once we release to production. But yest to reiterate, there are no permission issues, simply that the "Edit" button may appear, but still not let someone edit the data.