search

Rothamsted-Ecoinformatics / farm_rothamsted

Custom farmOS features for Rothamsted Research.
GNU General Public License v2.0
6 stars 1 forks source link

Experiment module: update status options #586

Open aislinnpearson opened 11 months ago

aislinnpearson commented 11 months ago

For the experiment module, please can we make the following changes to each of the Status options:

Researchers: no change. The full list should read 'Active' and 'Archived' Research Programs: Please can we add Completed so the whole list reads 'Requested, Active, Completed, Archived' Proposals: Please can we removed Postponed (replaced with Cancelled) so the full list reads 'Draft, Submitted, Approved, Rejected, Planning, Completed, Cancelled, Archived' Experiments: Please can we add Completed and Cancelled so the full list reads 'Requested, Planning, Active, Completed, Cancelled, Archived'. Designs: As per Experiments Plans: ** Please can we change Terminated to Cancelled so the full list reads 'Requested, Planning, Active, Completed, Cancelled, Archived' (the same as Experiments and Designs)

In addition, we'd also like to change the status options for Land, Plant and Structure Assets to

Land and Structure Assets: Please can we add 'Completed' and 'Discontinued' so the full list reads 'Active, Completed, Discontinued, Archived' Plant Assets: Please can we add 'Harvested' and 'Discontinued' so the full list reads 'Active, Harvested, Discontinued, Archived.'

I am not currently sure how to deal with plot assets, and think this might need some discussion.

A related issue here:

aislinnpearson commented 11 months ago

Possible error to keep an eye out for is instance where changing the status options affect the UI, so only active assets will be displayed. May need to be considered in further UI issues.

paul121 commented 9 months ago

In addition, we'd also like to change the status options for Land, Plant and Structure Assets to

Would it be OK if we hold out on this for another issue? I am a little worried about what will happen if these assets are not only active/archived and would like to think on it some.

aislinnpearson commented 9 months ago

Agreed that we would move this to milestone 2.20.0 for additional consideration/ to follow the update to FarmOS core version 3.0 (see issue #609)

@paul121 feel free to close this issue if you are happy.