search

Rothamsted-Ecoinformatics / farm_rothamsted

Custom farmOS features for Rothamsted Research.
GNU General Public License v2.0
6 stars 1 forks source link

User permissions: enable people listed as statisticians and data stewards to edit #591

Closed aislinnpearson closed 9 months ago

aislinnpearson commented 11 months ago

HI @paul121,

We found a specification error/ oversight in the user permissions today, whree people who are (1) research editors (or research leads) and (2) are only listed as data stewards or statisticians on proposals and experiments can't edit the proposals or experiments (they need to added as contacts on proposals or researchers on proposals in addition to being listed as data stewards and statisticans).

Could we please update this so the logic is:

Proposals: Research Editors and Research Leads listed as contacts, statisticians or data stewards can edit associated with Experiments: Research Editors and Research Leads listed as researchers, statisticians or data stewards on the experiment or Statisticians on the Design can edit associated with.

Ideally we'd update this as part of 2.17.1 as we are going through the process of adding Spring crop proposals now, but we can chat about it on Tuesday to see what's possible.

paul121 commented 11 months ago

Proposals: Research Editors and Research Leads listed as contacts, statisticians or data stewards can edit associated

I added this in 2.18.0.

Experiments: Research Editors and Research Leads listed as researchers, statisticians or data stewards on the experiment or Statisticians on the Design can edit associated with.

@aislinnpearson sorry I missed this - but Experiments only have a single "researcher" reference. We can do the "statistician" on the design, but I wanted to double check how that might overlap with experiment permissions.

paul121 commented 9 months ago

or Statisticians on the Design can edit associated with.

I've added this for 2.19. But @aislinnpearson can confirm that the Experiment permissions are working as expected, they only have a single researcher reference field?

aislinnpearson commented 9 months ago

@aislinnpearson to add this to the documented permissions and specify follow on issue of how Research Leads/ Research Editors are presented on Proposals, Experiments and Designs (see issue #610).

Happy for you to close this @paul121 if the new issue I have created answers your question (although it will need some additional specification work as mentioned in the issue).