Rothamsted-Ecoinformatics / farm_rothamsted

Custom farmOS features for Rothamsted Research.
GNU General Public License v2.0
6 stars 1 forks source link

Experiment Module: Update data fields associated with Contacts to reflect Permissions #610

Open aislinnpearson opened 9 months ago

aislinnpearson commented 9 months ago

Following the new permissions we created for the experiment module, we'd like to update the data fields on the Proposal, Plan and Experiment Entities so they use the same wording and concepts. Specifically:

Proposal Entity:

  1. The 'Contacts' data field is broken down into two data fields 'Research Leads' and 'Research Editors', and you can only add people who have the same permission. Thought would have to be given to what happens if you change the permission of a given person (for example, if someone is promoted to a Research Lead permission are they allowed to still have those permissions for all proposals they are associated with?). We also need to think about how any changes that would affect existing experiments.
  2. The 'Statistician' and 'Data Steward' data fields remain the same

Experiment Entity:

Once we agree on a format for the proposals, this same format should be applied to the Experiment entities, where the changes made would replace the existing 'Researchers' data field.

Design Entity: The design entity only references a Statistician, who has permission to only edit the design they are named on. This is how we agreed it should work temporarily, but we also need to assess if a Statistician is added on a Design then does that person also need to be named on the Experiment? Alternatively, perhaps you can only name a Statistician on the Design if they are already named on the Experiment?