Rothamsted-Ecoinformatics / farm_rothamsted

Custom farmOS features for Rothamsted Research.
GNU General Public License v2.0
6 stars 1 forks source link

FarmOS 3.0: Design Management tabs not visualising properly #620

Closed aislinnpearson closed 8 months ago

aislinnpearson commented 9 months ago

@paul121 and I have discussed this but I don't think I submitted an issue, but the management tab on the Design entity isn't rendering properly in 3.0.

image

image

paul121 commented 9 months ago

Unfortunately I don't think we'll be able to do these nested vertical tabs in Drupal 10. I believe this functionality may have been originally provided via the Field Group module but we needed to remove this module as it was conflicting with how the new vertical tabs in the Asset/log forms (see #612).

Reading these Drupal user interface standards for vertical tabs too, it says to not use nested vertical tabs nor multiple sets of vertical tabs on the same page. I think there is good reason for this.

A simple change would be to use a collapsible fieldset for each sub-management category. What do you think of this idea @aislinnpearson ? I will make the change and push to the demo site now so you can review.

Screenshot from 2024-02-20 14-39-58

aislinnpearson commented 8 months ago

I'm very happy with this. It looks good. Thank you Paul