Rothamsted-Ecoinformatics / farm_rothamsted

Custom farmOS features for Rothamsted Research.
GNU General Public License v2.0
6 stars 1 forks source link

Experiment module: rename plot_number as db_id #633

Closed aislinnpearson closed 6 months ago

aislinnpearson commented 6 months ago

Following the error observed in issue #632 we were having some discussions internally about the best way to differentiate between the human and computer legible versions of the plot numbers. I hate to ask this, but our farm team are quite insistent that plot number and plot id are very confusing. Instead they were asking if we can change plot number to something like 'database_id' or 'db_id'.

I realise this is a very big change, but also have to acknowledge their concern about misinterpreting plot numbers (and that it is probably better to request this as soon as they ask for it, before it becomes an even more intrenched naming convention).

aislinnpearson commented 6 months ago

We agreed that in issue #634 we would hide plot_number, and not rename it. We decided this because the db_id is very different in FarmOS and is assigned after the statistical randomisation. This won't be an issue if hidden.