search

Rothamsted-Ecoinformatics / farm_rothamsted

Custom farmOS features for Rothamsted Research.
GNU General Public License v2.0
6 stars 1 forks source link

Display a link to plan(s) on the log page #69

Open paul121 opened 2 years ago

paul121 commented 2 years ago

If you want to be able to go to a Log in farmOS and see that it was part of a particular Experiment plan, then I think there are two options:

  1. Explicitly reference the Logs from the Plan.
  2. Implicitly determine which Plan(s) a Log may be part of.

From @mstenta, more info in https://github.com/Rothamsted-Ecoinformatics/farm_rothamsted/issues/38#issuecomment-996722050

paul121 commented 2 years ago

For the rothamsted experiment plans I would really recommend we go with option 2. As described in the original comment there is some complexity with directly linking the plan and logs since we use the quick forms that reference plot assets, not the plan.

More generally, I'm curious if this feature could be partially provided by farmOS core. We could create a LogPlan block that allows other modules to populate information about the log -> plan relationship(s) with their own custom logic, such as the plan's plot asset logs.

This could be abstracted a step further to allow modules to populate "contextual" information more general than just log -> plan relationships, like a LogContext block. This could be useful for the REI module!

mstenta commented 2 years ago

I'm curious if this feature could be partially provided by farmOS core.

Yes I was thinking the same thing - let's do it!

aislinnpearson commented 2 years ago

Following on from our phone call this evening, being able to see all the logs associated with a plan is useful for the farm team and scientists. The issue works the other way around as well - if you click on a plot, you want to be able to see the full history of that plot. I realise that this is already the case, but I wanted to mention it because I can see a situation where you might want to navigate to an experiment and then filter all the logs associated with an experiment based on specific plots, or plot attributes.

Added complexity, sorry.

aislinnpearson commented 2 years ago

Agreed in the meeting on 12th January that this would become a Phase 1 issue as it also relates to FarmOS core and is also essential for the Restricted Entry Intervals (REIs).