Rothamsted-Ecoinformatics / farm_rothamsted

Custom farmOS features for Rothamsted Research.
GNU General Public License v2.0
6 stars 1 forks source link

Changing or amending logs created using quick forms #85

Open aislinnpearson opened 2 years ago

aislinnpearson commented 2 years ago

As described in the document attached to https://github.com/Rothamsted-Ecoinformatics/farm_rothamsted/issues/70#issue-1093250757:

"Ideally the new quick forms would have an edit function which captures any changes, the date of those changes and why they were necessary."

The date of the change could be (and may even be) stored electronically already within the log? The reason why the change is necessary is a nice added benefit but I can see many circumstances where this isn't essential - and some where it is (e.g. the experiments that information may be important). One for further discussion, as we are partly talking about versioning logs here, but also editing information in existing records via the quick forms.

paul121 commented 2 years ago

The date of the change could be (and may even be) stored electronically already within the log?

@aislinnpearson yes! This change history is saved in "log revisions". Whenever you edit a log a new revision is created. And each revision has an (optional) message text field that can be used to described the changes in that revision.

One for further discussion, as we are partly talking about versioning logs here, but also editing information in existing records via the quick forms.

Exactly. Right now this revision UI is available on the log edit page, but not from the quick forms. If and when we implement the "edit" functionality in the quick forms I see it being important to include the revision message there too.