Rothamsted / knetminer

KnetMiner - webapp to search and visualize genome-scale knowledge graphs
https://knetminer.com
MIT License
25 stars 16 forks source link

Gene Neighborhood and P-Value Filtering #692

Open Arnedeklerk opened 2 years ago

Arnedeklerk commented 2 years ago

Part 3 of 3. See 1 & 2.

Both of the below features should be filters added beside the existing key filtering. See my very rough sketch:

Filter

Gene neighbourhood The introduction of the updated Genome API returning Gene view using JSON, brings visible a visible "Distance" modifier, which I believe goes up to eight. Adding functionality to KnetMiner gene view to be able to cap genes which are at X Distance (hops) away from the seed node would be a great way for users to quickly filter to find the most relevant genes to their query.

It can be in the form of a stepped slider, ranging from 1-8, being default set to 8. There should be an 'i' which explains the functionality with text reading: "Max distance from seed gene(s)." - we can work on the text later.

P-Value filtering The P-Value is also being returned with the updated format/api.

Let's add a small dropdown where the user can specify an 'Evidence P-Value cutoff', which would remove evidences form the table that the user does not consider to be relevant.

Arnedeklerk commented 1 year ago

This will now again be done by us.

Initially we can think of an implementation for gene view, then network view and potentially evidence view.

Arnedeklerk commented 1 year ago

Just a reminder that @lawal-olaotan we need to brainstorm this a bit before starting with this task. The scope is constantly evolving...

Arnedeklerk commented 1 year ago

I've now updated the ticket to better reflect what I had in mind @lawal-olaotan

marco-brandizi commented 1 year ago

This is now a very different ticket. We might just add a neighbour distance field to the API, but should not start this significant change on the API before having fixed the already too much mess we got for infinite scrolling and filters.

KeywanHP commented 1 year ago

It's going to be a great step forward to be able to filter the evidences in Gene View based on their distance, p-value or other values. Note that every evidence will have a distance but p-value is only computed for a Gene List search.

Arnedeklerk commented 1 year ago

Here are the designs by Andrii from Empat: https://www.figma.com/file/1XRYUW1cF0WEZ1lcbO0VNe/KnetMaps?type=design&node-id=1101-17573&t=7RuyPJHamoWz4BYu-4

Arnedeklerk commented 1 year ago

FYI future readers: This is now to be KnetScore and Distance filtering. Filters are to be applied on the columns directly within the table and logic is being changed to never hide the table header.

Arnedeklerk commented 1 year ago

Hi @lawal-olaotan, image Still getting the distance bug. I'll take a look briefly too...

Arnedeklerk commented 1 year ago

Distances should be fixed now, @lawal-olaotan please review and please see the TODO re the styling: Reset and Apply/ spacing around box varies between distance and knetscore filters.

Arnedeklerk commented 1 year ago

Going back to 0 concept type filter resets table entirely and removes other filters too

Arnedeklerk commented 1 year ago

Functionality works! Keeping in testing for a while. Thanks