Rothamsted / knetminer

KnetMiner - webapp to search and visualize genome-scale knowledge graphs
https://knetminer.com
MIT License
25 stars 16 forks source link

Creating network from Evidence view shows two different graphs #728

Closed Arnedeklerk closed 1 year ago

Arnedeklerk commented 1 year ago

Keywan picked up during the training event that "The recent changes to Evidence View have introduced a bug. Clicking the number gives a different (wrong) result compared to ticking the box and clicking Create Network."

Image

Wrong: Image

Correct: Image

marco-brandizi commented 1 year ago

@lawal-olaotan. The problem is in the userGenes_evidenceNetwork click handler: it calls '/network' with the variable geneList, which isn't local to the handler (should be taken from the checkbox in the same row). This variable is defined in the previous loop over the evidence rows, so I guess the handler is just taking the last value.

For future enhancements, see the the comments left in the evidence table function.