Rothamsted / knetminer

KnetMiner - webapp to search and visualize genome-scale knowledge graphs
https://knetminer.com
MIT License
25 stars 16 forks source link

Deletion of Genome regions not working properly. #742

Closed marco-brandizi closed 1 year ago

marco-brandizi commented 1 year ago

This is a minor, let's decide about it together with other priorities about when to address it.

I'm working with ci-test and Chrome 111.0.5563.146, Firefox 111.0.1, macOS 13.2.1. I'm trying this workflow:

  1. Start from the initial Knetminer page
  2. Select T. Aestivum, then the "Grain Growth" example (currently, the last one). The example has two search regions in the Genome Region Search section.
  3. Delete the first region

The remaining region can't be deleted, as it should.

Also, If I select another example and then this one again, only the second region is shown.

The only way to actually reset the search form is via page reload.

This doesn't happen when I delete the second region instead (ie, the remaining first one can be deleted).

This test is a good candidate for the manual or automated tests mentioned in #733.

Arnedeklerk commented 1 year ago

@lawal-olaotan

Thanks for your initial resolve. Please note that there is still another bug, @marco-brandizi's second example.

If I:

  1. Select Triticum aestivum
  2. Pick Grain growth example
  3. Delete one region from the genome region
  4. Re-click the Grain growth query: it only adds back one region Same thing if you delete a region and then toggle between any other query (and then go back to Grain growth).