Rothamsted / knetminer

KnetMiner - webapp to search and visualize genome-scale knowledge graphs
https://knetminer.com
MIT License
25 stars 16 forks source link

Commits Introduces Json to Knetminer UI #767

Closed lawal-olaotan closed 1 year ago

lawal-olaotan commented 1 year ago
codesandbox[bot] commented 1 year ago

This branch is running in CodeSandbox. Use the links below to review this PR faster.
CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

marco-brandizi commented 1 year ago

@lawal-olaotan I've reviewed the 202306-genome-clientjson branch and looks fine, apart from minor changes.

I didn't review this PR, cause you can't send in both a branch and a PR, it becomes unclear what I should look at.

So,

  1. align the PR with that branch
  2. test (I didn't test my own changes, they're minor anyway)
  3. try to merge into master, which needs manual side-by-side comparison and copy-pasted. Let me know if you have issues with this

Thanks, M.