Rothamsted / knetminer

KnetMiner - webapp to search and visualize genome-scale knowledge graphs
https://knetminer.com
MIT License
25 stars 16 forks source link

Gene table view, Evidence detail box doesn't work anymore #777

Open marco-brandizi opened 1 year ago

marco-brandizi commented 1 year ago

When showing the gene table, if I click on one of the icon in the Evidence column, a box is shown that has links to PUBMED in case of publications, something else I don't remember for the other cases (Network view?):

The links don't work anymore, they raise this error:

evidence-table.js:758 Uncaught TypeError: Cannot read properties of undefined (reading 'replace')
    at toggleEvidencePopUp (evidence-table.js:758:45)
    at HTMLDivElement.<anonymous> (gene-table.js:467:5)
    at HTMLDivElement.dispatch (jquery-bstrap.min.js:32:39900)
    at v.handle (jquery-bstrap.min.js:32:36635)

I doubt this was caused by today's changes about #743, since the affected code hasn't changed (as far as I can see). In the 5.6 release, this looks disabled (eg, https://knetminer.com/cereals). @KeywanHP, do we still want this?

EDIT: maybe it's caused by the fact that the open/close click handler takes over the whole box (if I click on a corner, the box closes), so, when I attempt to click the box contents (a concept type, a concept label, a PubMed link), that click handler still attempts to find the box ID to close from the child element (which hasn't any ID).

KeywanHP commented 1 year ago

Yes we decided to keep it. It's a useful feature. However, the popup could benefit from a small make-over. We could show the new "graphDistance" property in the popup to make it even more useful! @marco-brandizi @marco-brandizi @lawal-olaotan @Arnedeklerk

Arnedeklerk commented 1 year ago

Yep, good idea...

marco-brandizi commented 1 year ago

We could show the new "graphDistance" property in the popup to make it even more useful! @marco-brandizi @marco-brandizi @lawal-olaotan @Arnedeklerk

Nice, for the moment, let's make it working again :-)

marco-brandizi commented 1 year ago

@lawal-olaotan, it seems I've fixed it [REF]