search

Rothamsted / knetminer

KnetMiner - webapp to search and visualize genome-scale knowledge graphs
https://knetminer.com
MIT License
25 stars 16 forks source link

Changing Evidence Distance removes KnetScore filter #782

Closed Arnedeklerk closed 1 year ago

Arnedeklerk commented 1 year ago

In gene view, after updating the Evidence Distance the KnetScore filter is removed.

@lawal-olaotan please investigate.

Arnedeklerk commented 1 year ago

I'm going to take this out of review. It seems better, but as discussed (I know it's not mentioned here yet), the Concept filter, KnetScore filter and Evidence filter all need to filter the data together. Right now I'm still able to lose filters by updating the Concepts after having changed the KnetScore filter. Once that's done if I go back to the KnetScore it appears on the slider to be getting filtered but it isn't being filtered until I again hit apply. I think already know this but just for clarity :)

marco-brandizi commented 1 year ago

In the 20230823-gene-table-filters-js-review there is a comprehensive review about this.

By the way, in ci-test, I don't see the distance filter anymore.

Arnedeklerk commented 1 year ago

Thanks Marco, will leave it to @lawal-olaotan as he's had much more to do with this than me.

re ci-test's filter: filters are moving to the headers again after discussing with Keywan. The dist filter is here and soon knetscore will be the same. image

Arnedeklerk commented 1 year ago

Thanks @lawal-olaotan