I have done a routine review of KnetMiner code, in preparation for 5.7. Regarding Javascript, we still need to address what follows.
user-access.js: there are still various issues and code to clean, I've reopened #768 with comments, have a look there
gene-table-filtering-draft.js: I had proposed a cleaner design of filtering code in this file. It looks like code remained where it was. At this point, I no longer know if a major overhaul is worth for a legacy release. If we decide not, the current code should be explained in a separated .md document, describing the logics, flow, and examples. That would be very valuable in case we still need to make small changes or debug it.
data-utils.js: genomeApi() has still a minor issue, see line 18
web-cache.js: apparently, this remained in the poor state it was before my review, but I ain't it clear if now we're using web-cache-new.js. We need to clean and finalise it, it can't go in a new release, not even a legacy release.
Misc Notes
data-utils.js, I moved openAccessionNetworkView(). Keep the testing code at the end of file. In general, sort things in a file according to some logical order, eg, more abstract and public stuff, implementation and internal details. Do not throw code in files in random order
I have done a routine review of KnetMiner code, in preparation for 5.7. Regarding Javascript, we still need to address what follows.
user-access.js: there are still various issues and code to clean, I've reopened #768 with comments, have a look theregene-table-filtering-draft.js: I had proposed a cleaner design of filtering code in this file. It looks like code remained where it was. At this point, I no longer know if a major overhaul is worth for a legacy release. If we decide not, the current code should be explained in a separated .md document, describing the logics, flow, and examples. That would be very valuable in case we still need to make small changes or debug it.data-utils.js:genomeApi()has still a minor issue, see line 18web-cache.js: apparently, this remained in the poor state it was before my review, but I ain't it clear if now we're usingweb-cache-new.js. We need to clean and finalise it, it can't go in a new release, not even a legacy release.Misc Notes
data-utils.js, I movedopenAccessionNetworkView(). Keep the testing code at the end of file. In general, sort things in a file according to some logical order, eg, more abstract and public stuff, implementation and internal details. Do not throw code in files in random order