Closed bschmalhofer closed 5 months ago
The version declaration was removed in rel-10_0. The changes were merged into rel-10_1 and rel-11_0. Starting and stopping containers still work for the three branches. Closing this issue.
There had been problems with 'docker compose' version 1.25. Needs to be investigated. First let's revert the change.
I tested the behavior, when version: '3.3'
is not declared with different versions of Docker Compose. The only case where this is a problem seems to be the standalone Docker Compose 1.25. This happens to be the default version that is installed in Ubuntu 20.04. The error is about
db:
image: ${OTOBO_IMAGE_DB:-mariadb:10.5}
user: mysql:mysql
Setting a default value, that is mariadb:10.5, is not supported without declaring version: '3.3'
.
As Ubuntu 20.04 is supported by OTOBO the workaround 5588594 has to be kept.
A remaining problem is that the tag rel-10_0_10 points to a commit where version: '3.3'
has been removed. Therefore that tag will be moved to the current HEAD of the rel-10_1 branch.
TODO:
Moved the tags:
Looks like the fix worked. Closing this issue.
With Docker 26.0.0 I get the following warning when starting up die OTOBO containers:
Those warnings are harmless but still irritating. According to https://docs.docker.com/compose/compose-file/04-version-and-name/ the version declaration can safely be removed.
The relevant code line is: https://github.com/RotherOSS/otobo-docker/blob/4d20e2d433c9655e54182172e52277b4982c92c2/docker-compose/otobo-base.yml#L9