Check the cases where autoclose of lexical variables is used

[bschmalhofer]

There are instances where the code relies on the autoclosing of lexical file handles are autoclosed. Autoclosing works just fine, however the scoping rules are a bit surprising. See https://stackoverflow.com/questions/67644504/why-does-repeatedly-opening-appending-and-closing-a-text-file-cause-the-lines-t and https://perlmonks.org/?node_id=11133380 .

Here is an example:

        if ( open my $ViewerDataFH, '>', $Filename ) {    ## no critic qw(OTOBO::ProhibitOpen InputOutput::RequireBriefOpen)
            print $ViewerDataFH $Data{Content};
        }
        else {

            # log error
            $LogObject->Log(
                Priority => 'error',
                Message  => "Cant write $Filename: $!",
            );

            return $LayoutObject->ErrorScreen();
        }

TODO:

• [x] check recent commits that meddled with close: git log -S close
• [x] check CodePolicy for untagged usage of open
• [x] check the code for problematic cases
• [x] add explicit close when open is called in an if or an for
• [x] runt test suite before closing the issue

[bschmalhofer]

Readd the close statement hat were remove in 08b155568c03649068a2d552b67bfe02402d45a7, even though it looks like no bugs were introduced in that commit. Checked the 91 file that have open statements and found no critical issues.

[bschmalhofer]

Test suite looks fine. Closing this issue.