RotherOSS / otobo

OTOBO is one of the most flexible web-based ticketing systems used for Customer Service, Help Desk, IT Service Management. https://otobo.io/
GNU General Public License v3.0
248 stars 71 forks source link

Appointment Calendar Notification could try to use expired PGP public keys #1987

Closed bschmalhofer closed 2 months ago

bschmalhofer commented 1 year ago

In Kernel/System/Ticket/Event/NotificationEvent/Transport/Email.pm there is a check of the PGP public keys.

    @EncryptKeys = $PGPObject->PublicKeySearch(
        Search => $Param{Recipient}->{UserEmail},
    );

    # Take just valid keys.
    @EncryptKeys = grep { $_->{Status} eq 'good' } @EncryptKeys;

See https://github.com/znuny/Znuny/commit/50373c74996668d0dca2e3c300b7ff231879015d

This check is not present in Kernel/System/Calendar/Event/Transport/Email.pm . As both modules provide similar functionality I would go for consistent behavior.

bschmalhofer commented 2 months ago

Closing, as the convention is that issues in the wishlist should be closed.