Unused settings for CKEditor

RotherOSS / otobo

OTOBO is one of the most flexible web-based ticketing systems used for Customer Service, Help Desk, IT Service Management. https://otobo.io/

GNU General Public License v3.0

241 stars 72 forks source link

Unused settings for CKEditor #3406

Open bschmalhofer opened 1 month ago

bschmalhofer commented 1 month ago

Currently the following settings are set up for the CKEditor in the methods SetRichTextParameters()and CustomerSetRichTextParameters() in Kernel/Output/HTML/Layout.pm. Some of these are unused:

Height, unused
Width, unused
TextDir, unused
Lang.SplitQuote, unused
Lang.RemoveQuote, unused
Plugins
Toolbar
ToolbarWithoutImage
ToolbarMidi, unused, commented out
ToolbarMini, unused, commented out
PictureUploadAction

It should be checked whether the unused setting are really not needed. If not needed then they can be removed.

stefanhaerter commented 1 month ago

Perhaps it does also make sense to have the CodeMirror editor in mind when checking. To the best of my knowledge, CodeMirror currently affects AdminTicketMask, AdminDynamicFieldSet, AdminITSMConfigItem and XSLT Mappings im Webservices.

bschmalhofer commented 1 month ago

Yes, some settings might also apply to CodeMirror. At least Height and Width should also apply to CodeMirror, unless these settings are ditched altogether.

stefanhaerter commented 1 month ago

As specified here

https://github.com/RotherOSS/otobo/blob/823daad743986c063d1195f9054ba14f32f99e71/var/httpd/htdocs/skins/Agent/default/css/Core.CodeMirrorEditor.css#L31-L36

I set the height of CodeMirror editors css-wise to 10 lines plus padding. Maybe it would be a nice enhancement to offer a sysconfig setting for setting the number of lines which is then translated into pixels.