search

RotherOSS / otobo

OTOBO is one of the most flexible web-based ticketing systems used for Customer Service, Help Desk, IT Service Management. https://otobo.io/
GNU General Public License v3.0
250 stars 72 forks source link

Align parameter usage of sub FormatTimeString #3634

Closed stefanhaerter closed 2 months ago

stefanhaerter commented 2 months ago

The parameter $Short can be passed to Kernel::Language::FormatTimeString()¹ to show a date without seconds. At every occation² besides two, this parameter is written as 'NoSeconds', the two exceptions use 1. As this is functionally fine, I suggest to align it for convenience and for making it easier to understand what is going on.

¹:

https://github.com/RotherOSS/otobo/blob/69dfb36ee690a1e658bb30ab6c9dfdb3b9454546/Kernel/Language.pm#L295-L304

² One Example for comparison:

https://github.com/RotherOSS/otobo/blob/69dfb36ee690a1e658bb30ab6c9dfdb3b9454546/Kernel/Modules/AgentTicketActionCommon.pm#L3468

stefanhaerter commented 2 months ago

Closed with merging #3635