Behavior when Showing or hiding deleted articles

bschmalhofer commented 3 months ago

Testing the behavior related to deleting articles in the AgentTicketZoom frontend. The system is a newly set up Docker installation using a local build of rel-11_0. The single article view in AgentTicketZoom was activated in the cases below. When viewing all articles everything seems to be fine.

Behavior where deleted articles are either listed or not

The button 'Show deleted articles' or 'Hide deleted articles' is not touched

Deleted articles are listed:

Not deleted article is deleted => article list is updated, deleted article still shown
Deleted article is restored => article list is updated, deleted article still shown

Deleted articles are now listed

Not deleted article is deleted => article list is updated, the initial article is shown
Deleted article is restored => does not apply

Behavior when the listing behavior is changed

The button 'Show deleted articles' or 'Hide deleted articles' is pressed. A followup article is viewed.

No deleted articles exist, thus the viewed article is not deleted

Clicking 'Hide deleted articles' => The first article is shown BUG
Clicking 'Show deleted articles' => The first article is shown BUG

A deleted article is viewed

Clicking 'Hide deleted articles' => The first article is shown, this is sensible behavior
Clicking 'Show deleted articles' => does not apply

There is a deleted article, but a non-deleted article is viewed

Clicking 'Hide deleted articles' => The first article is shown BUG
Clicking 'Show deleted articles' => The latest deleted article is shown, that can be considered sane behavior

Originally posted by @bschmalhofer in https://github.com/RotherOSS/otobo/issues/3636#issuecomment-2258118251

bschmalhofer commented 3 months ago

The bug is that the shown article changes when clicking on 'Hide' or 'Show'. This happens even when there is no reason for showing another article. But this is not serious, as the articles are still available via clicking in the list. Therefore I filed this as an enhancement issue for rel-11_1.

stefanhaerter commented 3 months ago

From a code perspective, the behavior seems quite logical, since the link format is:

Action=AgentTicketZoom;TicketID=[TicketID]#[ArticleID]

The DeletedArticles-Feature returns the ticket link, which per default shows the first article. It needs to be decided wether the behavior should be changed there, in this case the last viewed ArticleID needs to be handled within the HideShowDeletedArticles code.

RotherOSS / otobo