search

RotherOSS / otobo

OTOBO is one of the most flexible web-based ticketing systems used for Customer Service, Help Desk, IT Service Management. https://otobo.io/
GNU General Public License v3.0
244 stars 70 forks source link

Usage of base tags in html emails. #528

Open svenoe opened 3 years ago

svenoe commented 3 years ago

In the cleaning process for html emails \<base> tags are removed from the code. This was added to OTRS in 2013 as a bugfix, because the relative path used by some mail clients (seemingly outlook at that time) of images embedded via \<img> is affected by this, and destroyed those images.

I'm not sure about the current situation of how images are embedded by commonly used mail clients, but in my opinion \<base> should affect \<img>, thus the real error lies within those clients. Without \<base> we had an incident where relative links, submitted in one email did not work anymore now.

Any opinions on this? The OTRS bug is #8880, and was first handled in May 2013, OTRS commit c2eaa9585ca93262a3b454a36236471ed2cd1e08 . The affected file is Kernel/System/HTMLUtils.pm (and some tests), search for 8880.

bschmalhofer commented 1 year ago

I'm very much undecided about this issue. It makes kind of sense that incoming mails contain a base tag that are used for links and images of the original mail. But then I see that mailers might add their own images which are thrown off the track by the base tag. That whole topic is a bit murky, see e.g. https://medium.com/@ranadeepbhuyan/supported-html-tags-in-common-email-clients-2cc11e1ae283 .