Rothera / bpm

BetterPonymotes
GNU Affero General Public License v3.0
22 stars 23 forks source link

Fix the animotes target and jpm path in the Makefile #58

Open Calinou opened 6 years ago

Calinou commented 6 years ago

The animotes target will not work if the animotes directory does not exist, so an empty directory is now created before.

The task which requires jpm will now look for jpm in the PATH, so that one can just install it globally using npm or Yarn then run make.

bb010g commented 6 years ago

What if you don't want a global jpm install, though?

Calinou commented 6 years ago

@bb010g It's probably a better idea to rely on a local install indeed, so I guess node_modules/.bin/jpm could be used instead; ../../node_modules/.bin/jpm wasn't working for me (as it looked for jpm outside of the BPM directory). Would you like me to change this?

Ajedi32 commented 6 years ago

You'll have to wait and see what @Rothera thinks. Though personally, I'd prefer to npm init && npm install --save-dev jpm and commit package.json and package-lock.json to the repo. IMO as many build dependencies as possible should be in the repo itself.

ByzantineFailure commented 6 years ago

I second this.

On Jan 10, 2018 06:59, "Andrew Meyer" notifications@github.com wrote:

You'll have to wait and see what @Rothera https://github.com/rothera thinks. Though personally, I'd prefer to npm init && npm install --save-dev jpm and commit package.json and package-lock.json to the repo. IMO as many build dependencies as possible should be in the repo itself.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Rothera/bpm/pull/58#issuecomment-356627483, or mute the thread https://github.com/notifications/unsubscribe-auth/AEwr6VsfBFcPVwAlWVmpmYlo7n8fmfZCks5tJNBPgaJpZM4RYrQd .