search

Rotonde / beaker

Rotonde client with user account combined(deprecated)
MIT License
205 stars 37 forks source link

Single quotes break timestamp edit shortcut #25

Open roxaloxa opened 7 years ago

roxaloxa commented 7 years ago

If you click the timestamp on your own message that has a single quote in it like look at me, i'm gonna break!, then the command prompt will prefill with something like edit:10 look at me, i and truncate after the single quote.

screen shot 2017-10-13 at 10 57 07 pm
roxaloxa commented 7 years ago

I saw your comment @neauoire about fixing this. I tested:

screen shot 2017-10-14 at 11 23 39 am

Looks like it removes apostrophes from the message, is that intended?

neauoire commented 7 years ago

It's.. an improvement.

neauoire commented 7 years ago

I'll try to make the htmlescape work.

roxaloxa commented 7 years ago

What about the data-operation field just having like "edit:7" in it and when you click, it pulls the message itself from the local data after parsing the ID out?

Sticking the whole message in the attribute is kinda unwieldy