Closed 0x0ade closed 6 years ago
That is a lot of changes, I want it all, could you fix the css conflicts and I ll merge. You seem to have respected the current coding style. I think this is a pretty sold build. I don't see why I wouldn't merge as-in and build upon 👍
😍
Thanks for merging it so quickly and for fixing the css issues! It's 00:25 here in Germany and I can't fall asleep anymore - am too excited to boot up my PC after uni tomorrow :D
I didn't want this to be merged "prematurely" because I didn't want to introduce any bugs without others testing it (had to fix some bugs after the initial -mod "merge").
It's great to hear that everything's working as it should :)
Again, thank you for rotonde!
@neauoire @0x0ade i think this did break a few things
i'll see if i can fix it, but no promises
I fixed that, I'm working on making sure the tabs's width don't shift, and that the feed displays on load. There are still few things before we can start seeding this, but overall, well worth it 👍
whoa, that's quite a handful — great job!
the message counter seems to work now, and I do like your way of counting them in Feed.refresh
. this is even better than what I had in mind :+1:
I honestly don't expect this PR to be merged as-is, but hope that at least parts of it will find their way into rotonde-client.
This will hurt a little because
Feed.refresh
now counts more than it should (sorry, @eelfroth )r.home.feed.page
is being used in discoveryHome.update
The good news, though, is that the pagination and the related element reuse changes reduced the crash rate. We're not manipulating the DOM via
innerHTML
as aggressively anymore. I assume Beaker 0.8 will just deal with DOM updates better?This adds the following features:
Visible/All
in tab titlepage:#
(alt:page #
),++
,--
{%image.svg%}
=><img>
, src =`/media/content/inline/image.svg
(currently default file format if none given:.png
)body #feed .entry .message .inline { display: inline-block; margin: 6px 4px -6px 4px; height: 24px; }
/media/content/inline/
I didn't include
.ext#URL/.
media support because it requires/media/content/.ext/index.html
redirecting towindow.location.hash
for backwards-compatibility and because it allows non-self-hosted media.