Add portal.dat ~ DatArchive.resolveName(url), use it over dat in portal.json

Rotonde / rotonde-client

Rotonde Base Client

https://client-neauoire.hashbase.io/

MIT License

227 stars 49 forks source link

Add portal.dat ~ DatArchive.resolveName(url), use it over dat in portal.json #116

Closed 0x0ade closed 7 years ago

0x0ade commented 7 years ago

Related discussion on Twitter, linking to thread tail: https://twitter.com/lechd/status/929056891409453056

The dat field in portal.json is just causing issues and @neauoire told me about DatArchive.resolveName, which is preferable for every use case in rotonde right now (except for when someone wants to "update" their portal to a new dat).

This makes portal.hashes() (used in f.e. is_known, mention / whisper checking) effectively return the result of resolveName.

dat in portal.json is now useless (can't find anything using it anymore), but it's still being kept as old client versions use it.

neauoire commented 7 years ago

You're the best

eelfroth commented 7 years ago

I will need the dat in portal.json for something I have brewing

neauoire commented 7 years ago

Please don't, use resolveName :) or portal.archive.url if you're looking for your own. I was thinking about adding an index.html page to the client repo with on boarding instructions, what do you think?

0x0ade commented 7 years ago

If you've already got a portal instance, just use its .dat - it's basically a cached result of resolveName :)

I welcome a index.html page with on boarding instructions... but I'm wondering: Is it possible to modify the DatArchive created by DatArchive.fork(url)? If so, we could just create a "create portal" button that

forks @neauoire's "rotonde-portal"
resets the portal.json
sets up the name, description, site based on the values in a form on the website
window.location = fork.url

This would make the process to create your own portal:

Go to dat://2714774d6c464dd12d5f8533e28ffafd79eec23ab20990b5ac14de940680a6fe/
Fill out the form with your name, description, site
- Optionally: Already allow the user to upload their .svg avatar in this step, then store it once the fork's created
Hit "create portal"
Confirm the fork popup

It won't teach the user how to use the edit command, though.

neauoire commented 7 years ago

I wish, that would be such a new feature for 0.78 @pfrazee.

0x0ade commented 7 years ago

I just checked myself - we already can! Throwing together an ugly (unstyled) "new portal" concept index.html in my repo

pfrazee commented 7 years ago

I've been summoned.

I welcome a index.html page with on boarding instructions... but I'm wondering: Is it possible to modify the DatArchive created by DatArchive.fork(url)

Yes, you can edit any dat that you create, either by .fork or .create. Was that what you were talking about @neauoire ?

webdesserts commented 7 years ago

If so, we could just create a "create portal" button that

I already made something like this (doesn't modify the svg atm). Got caught up with work and never announced it: dat://af5ef11cdb370a641bf9a95854b74f42bf445e84969c05968f5385f7cde7487d/

webdesserts commented 7 years ago

I'll work on adding an svg upload today.

0x0ade commented 7 years ago

Moving the discussion out of this PR so others can see it more easily #117

Personally, I'd just love to see your launchpad integrated into rotonde-client, or at least being referred to from louis' guide :)