search

Rotonde / rotonde-client

Rotonde Base Client
https://client-neauoire.hashbase.io/
MIT License
227 stars 49 forks source link

microcommit: open links in new tab #187

Closed kodedninja closed 6 years ago

kodedninja commented 6 years ago

I think it would be better if links in the entries would open in new tab.

saulhardman commented 6 years ago

Chiming in: shouldn't we leave this up to the user? E.g. Right-click > Open Link in New Tab or ⌘ + Click.

Introduces a possible vulnerability too: https://www.jitbit.com/alexblog/256-targetblank---the-most-underestimated-vulnerability-ever/

kodedninja commented 6 years ago

@saulhardman Thanks for the vulnerability! The Right-click > Open Link way is pretty annoying in my opinion, because most of the time you want to see the content and come back to the page. Also Rotonde loads pretty slow.

I'll fix the vulnerability with rel="noopener" and let's see what others say. :)

yhancik commented 6 years ago

I tend to open a lot of new tabs, but I also believe it's best practice to leave the user chose if they want a new tab or not. (also don't we all open new tabs with middle-click?)

kodedninja commented 6 years ago

@yhancik what about laptop guys? :P

yhancik commented 6 years ago

Oh yes I tend to forget that! I can't stand trackpads so I always use a mouse regardless :p

kodedninja commented 6 years ago

@yhancik should I close this then or leave it open for now?

yhancik commented 6 years ago

No idea! Leave it open for more feedback?

0x0ade commented 6 years ago

LGTM and I'm welcoming this change :) Let's wait for what @neauoire has got to say.

TIL about the target='_blank' vulnerability.

neauoire commented 6 years ago

That's something I will use a lot.