search

Rotonde / rotonde-client

Rotonde Base Client
https://client-neauoire.hashbase.io/
MIT License
227 stars 49 forks source link

Escape file names to accommodate valid characters #56

Closed crteal closed 6 years ago

crteal commented 6 years ago

Fixes #53

I tested this pretty extensively (in the manual, and drag and drop cases), but I'm not quite sure what the intent of the removed split was. If there is something I missed there, please let me know!

crteal commented 6 years ago

It occurred to me this morning that the intention of split was probably to allow additional text after the image. I think that means that something more powerful than split (like a bonafide parser, or a regular expression) will need to be utilized to support more filenames (as my change does), as well as text after the image (which the current behavior provides). Another option might be adding another delimiter (e.g., TEXT >> MEDIA_NAME.jpg << TEXT).

crteal commented 6 years ago

Thanks @neauoire!