search

Rotonde / rotonde-client

Rotonde Base Client
https://client-neauoire.hashbase.io/
MIT License
227 stars 49 forks source link

visitors filter by portalname + validate clear_filter immediately upon injection #63

Closed eelfroth closed 7 years ago

eelfroth commented 7 years ago

currently, when you visit another user's Rotonde page, you see their feed much like they would see it. This sometimes makes it difficult to see what they themselves have posted. this PR changes this, so that by default the feed is filtered for their @name if you are not the owner of the page. to make it possible to still see their full feed (including posts by others that don't mention them) if one so desires, I made it so that filters get removed immediately upon clicking the "filtering by …" message. feel free to change this behavior if you have a better solution.

ianh commented 7 years ago

Yeah, it would be nice to have people's posts visible on their profile! It might be worth discussing whether this is the particular way we want to do it, though. Maybe a github issue would be a good place to discuss? I'm happy to merge this if we agree it's the right way.

eelfroth commented 7 years ago

ok, opened an issue #68

eelfroth commented 7 years ago

made some changes to the requested code, while keeping the same functionality. 83c9e2d adds a validate boolean attribute to the "filtering by…" element as a less hardcoded way to validate a data-operation without having to press enter on the operator.

ianh commented 7 years ago

Cool, let's merge this and try it out.