Rottenbeer / ItemRack

ItemRack working for WoW Classic
41 stars 45 forks source link

Fix "calling 'GetName' on bad self" #264

Closed romracer closed 2 months ago

romracer commented 5 months ago

In 4.1+ clients, which all modern and classic WoW clients are long descedents from (all clients are 10.0+ now), GetMouseFocus() can return nil when opening character frames (player or others like inspecting). This fixes calling GetName in those situations. Its probably a little overkill, but it works.

Rottenbeer commented 2 months ago

Sorry for the delay. Is this still relevant?

Rottenbeer commented 2 months ago

@romracer I guess it's not longer needed after https://github.com/Rottenbeer/ItemRack/pull/270 checks for nil?

romracer commented 2 months ago

This is still relevant even with #270.