search

Rottenbeer / ItemRack

ItemRack working for WoW Classic
40 stars 43 forks source link

Check for valid bag slot before adding tooltip to it #267

Open DJSchaffner opened 4 months ago

DJSchaffner commented 4 months ago

This fixes issues with custom buttons with custom tooltips from other addons.

Example: BetterBags creates a dummy button for displaying empty bag slots.

Before: grafik

After: grafik

Rottenbeer commented 1 month ago

Sorry for the delay. Is this still relevant?

DJSchaffner commented 1 month ago

I am currently not actively playing SoD/Classic and have been using a fork from @romracer with this issue being fixed, so one of his open pull requests might also fix this problem. But in general this problem is probably still relevant.

Rottenbeer commented 1 month ago

@DJSchaffner can you rebase this please?

DJSchaffner commented 1 month ago

Will take a look at it tomorrow evening :)

romracer commented 1 month ago

My fork has #259 applied which makes this PR not relevant. Since that's been merged here, this can probably be closed.